block
Bug: Fix Docs Webpage Broken Links
Hi, @angiejones,
Based on my observations before working on the issue, when I left-clicked on the cards on the webpage at "block.github.io/goose/v1/extensions/", the navigation worked as expected within the same tab. However, when I right-clicked and selected "Open in a new tab," I encountered a "Page Not Found" error.
There were no such issues when using localhost.
Looking forward to your review. Thank you.
Hi! Thanks for sending this in. Testing this out but doesn't seem to resolve it yet. As you mentioned, this error doesn't happen in localhost until you serve the build. In the meantime, can you also unstage the changes in the files outside router & details if they aren't relevant to this fix @Lymah123
I'm also unsure if this fixes it yet. The added react-router-dom isn't part of the dependencies so the build is failing. @Lymah123
Thanks for the feedback @acekyd , what do you think would be the best approach? From my research, I learned that GitHub pages doesn't natively support Single Page Application routing which potentially caused issue with deep link. A reason I came up with a 404 fallback by adding a 404.html that mirrors the index.html and included script that handle routing.
I tried testing it locally. I am open to your suggestions.
I will unstage the files you asked me to.
I'm also unsure if this fixes it yet. The added
react-router-domisn't part of the dependencies so the build is failing. @Lymah123
Okay, I added that because I was facing issue while I was trying to run it on my local machine. I can remove it before pushing.
Hello @acekyd , I am waiting for your response. Thanks.
I'm also unsure if this fixes it yet. The added
react-router-domisn't part of the dependencies so the build is failing. @Lymah123
Hey @Lymah123! Thank you for your patience - apologies for not getting back to you earlier. I did run some tests and the changes here did not fix the issue at the time. We've made a few changes to the general implementation since then, so the bug no longer applies as well. I'll have to close this pull request. Thanks again for contributing.