goose icon indicating copy to clipboard operation
goose copied to clipboard

Goose makes IntelliJ's "find all" command unusable for Dvorak keyboards

Open SalvatoreT opened this issue 9 months ago • 2 comments

Describe the bug

Unfortunately globalShortcuts don't work for alternative keyboards (https://github.com/electron/electron/issues/19747).

Goose uses a globalShortcuts for ⌘ ⇧ Y for installing an MCP extension.

https://github.com/block/goose/blob/cfd3ee8fd9c56011dc2689f009f75a1dc86d11fa/ui/desktop/src/main.ts#L551-L554

To type the letter "F" using a Dvorak keyboard layout, you actually press the "Y" key.

Therefore if Goose is open and you try to use a "Find All" command (in an IntelliJ IDE or anywhere else that uses ⌘ ⇧ F), Goose will intercept the command and show you a pop-up.

To Reproduce Steps to reproduce the behavior:

  1. On macOS, set your keyboard layout to Dvorak
  2. Open Goose
  3. Open IntelliJ and try to use the find all command (⌘ ⇧ F, but you'll be pressing the physical "Y" key to get the "F")

Expected behavior The "Find All" window should pop-up.

Screenshots Image

Please provide following information:

  • OS & Arch: macOS 15.3.1, ARM
  • Interface: UI
  • Version: v1.0.10
  • Extensions enabled: Developer, Memory, Jetbrains
  • Provider & Model: gpt-4o

Additional context This is a known issue with Electron.

SalvatoreT avatar Feb 27 '25 22:02 SalvatoreT

Got it! Sorry for the pain here @SalvatoreT

Thoughts on a resolution? This is a debugging only workflow so I could just remove it, but could be good to move it to something else that doesn't interfere. Trying to think of a way to do so where I know I won't be interfering with a key combo in another app.

alexhancock avatar Feb 28 '25 20:02 alexhancock

Removing it would work.

If there was a way to selectively deactivate shortcuts, that'd leave the functionality for most folks without changing too much.

SalvatoreT avatar Feb 28 '25 21:02 SalvatoreT

@SalvatoreT Should be fixed by removing the associated code. It was a debugging workflow we didn't really need anymore.

alexhancock avatar Mar 03 '25 20:03 alexhancock

Thank you!

SalvatoreT avatar Mar 03 '25 21:03 SalvatoreT