blaine comments

Results 71 comments of


                                            blaine

Run monorepo test suite against state resulting from proposal

Closed by: https://github.com/ethereum-optimism/superchain-ops/pull/555

Automatically run tasks in CI if task is in a non-terminal state

Closing as this is implemented with stacked simulations.

Check domain hash from simulation matches VALIDATIONS.md hash entry.

This code below (subject to change) goes into the circle ci config: ``` # Simulate any non-terminal tasks that will eventually be executed. simulate_non_teminal_tasks: circleci_ip_ranges: true docker: - image: environment:...

Check domain hash from simulation matches VALIDATIONS.md hash entry.

Closing this as it's implemented as part of stacked simulations now.

Print state diff in markdown format

We should also try to include the domain + message hashes in the markdown here that can be copied so we don't have to constantly make sure they're up to...

Print state diff in markdown format

Closing as this has been implemented.

Refactor signFromChildMultisig to reduce noisy terminal output

I think superchain-op's architecture has changed meaningfully since this issue was created. For that reason, I'm going to close this issue. Please let me know if I am missing something.

feat: Added in link validation

I think the general approach should be: 1. Raise an issue with a clear problem statement and proposed spec 2. Get buy-in 3. Then raise a PR (That said, if...

Support for "stacked" proposals that have incrementing nonces

Closed: https://github.com/ethereum-optimism/superchain-ops/issues/447 as it looks like a duplicate of this task.

Support for "stacked" proposals that have incrementing nonces

Great suggestions in this issue. @Ethnical, I haven’t had a chance to fully review your PR yet. I wanted to put some thoughts down on how I might see this...