mage-enhanced-admin-grids icon indicating copy to clipboard operation
mage-enhanced-admin-grids copied to clipboard

Published 20 hours ago • verified publisher icon blmage

Export fixes

Open mwgamble opened this issue 9 years ago • 3 comments

  • Fix issue with exporting more than 1000 items in a grid at one time. If you attempted to export more than one page worth of results for a grid whose collection modifies the select object to add new column correlations in the _beforeLoad() method, you would get an error because it would attempt to create the correlation on every page iteration of the export process.
  • Fix issue with exporting any number of items. You would always get one more than you asked for.
  • Fix general issues with Transactions grid due to it not resetting the collection object when preparing the collection for a 2nd time.

mwgamble avatar May 20 '15 09:05 mwgamble

Thanks for the fixes to the transactions grids !

Regarding the number of exported items, I get the opposite behaviour : the exported count is correct when using if (++$exported > $total), and I get one less than expected when using >= instead. Can you check on your side if you get one too many result due to the value of $total being altered at some point, or due to some specific use cases ?

mage-eag avatar May 20 '15 11:05 mage-eag

My apologies, there was indeed a bug in our code. We had inadvertently moved the call_user_func_array call above the if statement in question. The rest of the PR is still necessary to view and export items in the transactions grid, so I'll update it soon.

mwgamble avatar Aug 03 '15 07:08 mwgamble

Hi, I just wanted to let you know that I've rebased this branch on top of the latest commits from the 1.0.0-wip branch to resolve the merge conflicts that were there. You should be able to safely merge it in now.

mwgamble avatar Nov 16 '15 02:11 mwgamble