monkey icon indicating copy to clipboard operation
monkey copied to clipboard

Modman and git submodules

Open devolonter opened this issue 11 years ago • 2 comments

Yesterday I tested new module manager. It seems, everything works perfectly with all modules and repositories. But I’ve noticed that manager runs git clone without --recursive option. So, if module uses git submodules, directory with submodule will be empty after installing.

I’ve tried to just add the --recursive option, but it didn’t work. The installation was not completed, and I had to kill the git process manually... Although it works fine if I run the same command directly from the command line

I would like to know if there any chance that the git submodules will be also supported. Or I should refuse from having them in my repositories?

Thanks!

devolonter avatar May 16 '13 15:05 devolonter

Will have a look at this eventually - do you have any immediate need for it?

Git does seem to start sub-processes up in a 'weird' way, enough to mean I couldn't cheat and just use shell commands with redirected stdout to drive everything. Which was probably for the best as it meant I had to write brl.process - which is probably where the issue is.

blitz-research avatar May 19 '13 02:05 blitz-research

No, it’s not urgent. At the moment I use submodules in flixel repository only for examples and 3rd party plugins. So, the module works fine without them.

Also, you can try to solve the issue with another command for getting submodules:

git submodule update --init after git clone

This command works not recursively.

P.S. Just for the information. Using submodules also require changes in the update method. You need to add run git submodule update after git merge

devolonter avatar May 19 '13 22:05 devolonter