Martin Ross
Martin Ross
We should distinguish between incremental builds (running OpenRewrite on an delta changed set of files) and up-to-date checking. For up-to-date checking you just need to declare the inputs (which can...
For the nice-to-haves Lombok can give you the signal you need. e.g. @Value, @Equals, etc. are all well known patterns to signal that those methods can be removed, etc.
Yes this.getAllConfigs() is a Lombok generated method. There are three method calls here though. treeToValue
So tactically I would change the logic such that if any nested method call (regardless of its input params are known or not) have throws it should not remove. Right...
Sorry yes I should have specified if there is only a single method variant (i.e. No overloading). I filed another bug in a similar vein which is slightly different here...
Ultimately what think is needed for all of these annotation processors is a mechanism where rewrite has access to the paired byte code generated at compilation time. AST analysis will...
Or a at a minimum if you want to keep pure AST analysis you need to pair with the delomboked source
Working at Amazon and previously worked at Google which both operate at scale you need to minimize false positives so +1. That being said with Lombok the private fields are...
Hi. Sorry. Are you asking for something from me?
This needs #925 as a prequisite.