blinkysc

Results 75 comments of blinkysc

> Since multiple map threads may exist, this results in concurrent writes without synchronization mechanisms, along with concurrent read/write issues. > I would move the playerbot login code to the...

Yeah I’m not thinking mutex way to go now either. Walkline made suggestions that made the most sense. I put it in this issue ticket https://github.com/liyunfan1223/mod-playerbots/issues/1124

This PR wouldn't address these crashes, I would add them to new Issues. Also the second is purely AC? So maybe not the second? I couldn't say for certain if...

> I'm a bit worried that using mutex and exception catch is overprotective and hides the underlying problem. Maybe it can be used as a test branch first rather than...

> Once the server froze without crashing. I assume after this PR? This can be Mutex deadlock. I don't really have any lock ordering or timeouts for the mutex, but...

> > I assume after this PR? > > Yup. Previously, no freezes were observed. Comment out the mutexes and imports while keeping everything else in ```c++ PlayerbotMgr.h // Around...

> Can this lead to more crashes? Should I expect that the server will crash more often than now? (For example, as before this fix) There is try catch ~~more...

> > Can this lead to more crashes? Should I expect that the server will crash more often than now? (For example, as before this fix) > > There is...

I'll keep trying my best with this myself =)

🤖 **Analysis by AI Assistant with MCP** ## Summary The error message "Trial accounts cannot invite characters into groups" appears when trying to leave a party in a BG/Arena because...