blink
blink copied to clipboard
Smart Key bar not showing up
Checklist
- [x] Read the docs
- [x] Searched for existing GitHub issues
Configuration
Xcode: 16.0 (16A242d) Blink: v18.0.0.927 (Test Flight). Sep 28 2024. branch: default (raw) iPadOS Version: 18.0
Describe the bug
This is a brand new checkout, following the installation guide in the Build section of the README.md file.
The Smart Key bar is not showing up. In Settings.app->General->Keyboard->Shortcuts-toggle, I tested with both - switch on or off I don't use assistive touch
I built from GitHub repo and deployed in release mode to
- physical device: iPad Pro (11 inch) (4th generation), iPadOS 18.0
- Simulator: iPad Air 11 inch (M2), iOS 18.0
On my device I tested without and with hardware keyboarrd attached. In the sim I tested without or with hardware keyboard setting.
Thus bug is only related to iPad. Smart key bar shows up on iPhone.
Following this workaround: #1898
In Blink/Smarter Keys/SmarterTermInput.swift I changed line line 180 from
if KBTracker.shared.isHardwareKB {
to
if isHardwareKB {
Actually, I didn’t understand the logic behind this change but now, the Smart Key bar is always shown.
but with this workaround the smart key bar looks scambled and is not usable when a physical keyboard is attached
This is a known issue with iOS and we have reported it multiple times. Won't dig deeper as the plan is to rewrite the SmartKeys bar and the Terminal itself.