blink icon indicating copy to clipboard operation
blink copied to clipboard

Smart Key bar not showing up

Open unoctanium opened this issue 1 year ago • 3 comments

Checklist

Configuration

Xcode: 16.0 (16A242d) Blink: v18.0.0.927 (Test Flight). Sep 28 2024. branch: default (raw) iPadOS Version: 18.0

Describe the bug

This is a brand new checkout, following the installation guide in the Build section of the README.md file.

The Smart Key bar is not showing up. In Settings.app->General->Keyboard->Shortcuts-toggle, I tested with both - switch on or off I don't use assistive touch

I built from GitHub repo and deployed in release mode to

  1. physical device: iPad Pro (11 inch) (4th generation), iPadOS 18.0
  2. Simulator: iPad Air 11 inch (M2), iOS 18.0

On my device I tested without and with hardware keyboarrd attached. In the sim I tested without or with hardware keyboard setting.

Thus bug is only related to iPad. Smart key bar shows up on iPhone.

unoctanium avatar Sep 28 '24 14:09 unoctanium

Following this workaround: #1898

In Blink/Smarter Keys/SmarterTermInput.swift I changed line line 180 from

if KBTracker.shared.isHardwareKB {

to

if isHardwareKB {

Actually, I didn’t understand the logic behind this change but now, the Smart Key bar is always shown.

unoctanium avatar Sep 29 '24 16:09 unoctanium

but with this workaround the smart key bar looks scambled and is not usable when a physical keyboard is attached

unoctanium avatar Sep 30 '24 22:09 unoctanium

This is a known issue with iOS and we have reported it multiple times. Won't dig deeper as the plan is to rewrite the SmartKeys bar and the Terminal itself.

carloscabanero avatar Oct 02 '24 19:10 carloscabanero