bookworm
bookworm copied to clipboard
blindpandas
Add the ability to restore settings to default
There is currently no way to restore the default settings in each category.
Describe the solution you'd like
Add a button to restore default settings in each category, and if possible, also add a button to completely reset Bookworm settings for all categories.
I think adding these two buttons will help users a lot in different scenarios, for example, if they want to reset only reading preferences or another specific category, they can just go to that category and restore default category settings or, if there a full reset is required, they can press the corresponding button and the settings will be reset.
In both cases, a dialog box should also appear informing users that the reset was successful, with an OK button or a close button to close the dialog box.
Hi there. As said on the tellegram group, I'd love to take on this issue. I've taken a look at the code I might be changing. Just to make sure, each pannel basicly requires a "reset to defaults" button right? then mabey just before the "Apply" button, a button that says "reset all settings"?
Hello @ashleygrobler04 Yes, each category requires a button to reset only a certain category and, in addition, a complete reset, which can basically have a name, reset all settings, and which allows you to completely reset Bookworm settings.
Hello @ashleygrobler04 @DraganRatkovich
I don't think we need to have a reset all button. We can just add a menu item to the file menu that can revert all config values to their defaults, and I think even that is unnecessary.
Best Musharraf
@ashleygrobler04
You don't need to add the 'Reset' button to each SettingsPanel subclass.
Just add it to the base class of all settings panels (bookworm.gui.settings.SettingsPanel), and it will be inherited by all its subclasses.
In the event handler, you can retrieve the current config section by using self.config_section.
Hi @mush42 At least one of the options must be enabled, because if the user only wants to reset certain category options, well, the option to do so will be in that category or, if the user needs to do a full program reset, again the corresponding button must exist. Not sure, choose the right one.
@DraganRatkovich the category reset button is the primary feature. But the question is: do we need a reset all button?
@mush42 Yes, you need to add it to reset all settings to default, but again, it's entirely up to you.
I don't think the ability to reset all config is much necessary. Of course this is just my personal opinion.
Thinking about this, I don't think a reset settings button is needed, since the user can just go ahead and delete the config files if needed. If a reset settings button is required, not 1 button for each category, but rather 1 button that resets all the settings entirely.
@ashleygrobler04 No, deleting configuration files is not suitable for most users. Why do they have to deal with files when a button can do the rest of the work for them? Okay, I understand that you can't just add a reset all settings button, but resetting a category is important!
@cary-rowen Due to the fact that every program these days supports resetting to default values, I thought it was important.
@DraganRatkovich maby just the reset all settings option then? if it is ok with @mush42 .
@ashleygrobler04 I'm not sure, it's entirely up to you and @mush42 because you can add it as a developer. For me, each setting is important from the point of view of the user, who needs to either reset all settings to default values, or individual category settings.
Ok, no probs. will do so. I don't know by when I will be done since I got college keeping me busy. Tomorrow is the last day of the week that I will have class, after that I'll start work on it if that is ok with you. Or if there is a spessific deadline I need to meet let me know.
@ashleygrobler04, any progress on this issue? I'd definitely use this feature.
Hi there. I am sorry for not doing mutch. I haven't had the time to provide any contributions. College keeps me quite busy and life is just a little too hectic at the moment. Would it be possible for someone else to take care of this issue?