zsh-aws-vault icon indicating copy to clipboard operation
zsh-aws-vault copied to clipboard

Feature/improve yubikey usage

Open nbrys opened this issue 4 years ago • 1 comments

Improve the usage of yubikey for other av commands

nbrys avatar Jan 12 '22 11:01 nbrys

Hey @nbrys - thank you for proposing this contribution! The one issue with moving from an alias to a function is that we lose the default auto-completion behavior.

Before

Type avl + space and then press the Tab key. You'll see your profiles appear as autocomplete suggestions:

Screen_Shot_2022-01-15_at_9_55_03_AM

After

On this PR, since avl (and others) moved to a function, autocompletion of profiles no longer works.

Screen Shot 2022-01-15 at 9 56 46 AM

(you'll see in the screenshot it's suggesting foo.txt, a file in the demo directory, not my aws-vault profiles).

Solution

I'm happy to accept a changeset, I just want to make sure that we don't lose the autocomplete functionality that existed before this change. @reegnz submitted a PR a while back that focused on improving autocomplete, which might be interesting to take a look at: https://github.com/blimmer/zsh-aws-vault/pull/21

blimmer avatar Jan 15 '22 16:01 blimmer