vue-rangedate-picker
vue-rangedate-picker copied to clipboard
bliblidotcom
Add overlay, initial preset and selecting backward ability
This PR adds the following behaviour:
- It sets up the date picker to accept an initial preset, so you can start with last30days selected for example.
- It adds overlay and cancel button stylings that are hidden by default but can be turned on by passing in prop cancelButtonHidden="false" The overlay hides the date picker when you click outside.
- This fix also allows you to selects dates by selecting the end date first.
- It also allows you to select within the same month.
- A new prop 'maxDate' has been added to prevent selecting past a give date. Keen for any feedback, be great to see this merged.
Hey @blibliandirdjunaedi! Would you mind having a look at your Travis build settings? It looks like it's throwing a setup error:
03 07 2018 02:45:42.884:ERROR [launcher]: ChromeHeadless stderr: [0703/024542.754917:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/google/chrome/chrome-sandbox is owned by root and has mode 4755.
We'd love to move this along @okoriko , but it looks like we're going to be blocked by your CI requirements on this repo. While our branch might have some issues, it looks like master does too.
If you could (please <3) get master passing, we'll try get this branch green including that bugfix.
Hey @okoriko , is CI still a requirement for merging on this repository?
I haven't seen changes to master in a loooooooong time. Has bliblidotcom abandoned development on this project?
@heymatthew I'm not the owner, nor a contributor on this repo, I'm afraid I can't help you with this :disappointed: I was just pointing out what seemed to be a bug to me while checking this PR.
Sorry @okoriko , thanks for the code review I wasn't looking to offend. My bigger worry is that we can't communicate with upstream and I thought that your code review indicated that you might be able to change that.
There's clearly an appetite for this plugin to be maintained. That two non core devs are reviewing and trying to contribute upstream is pretty clear evidence that this project has legs.
I've raised https://github.com/bliblidotcom/vue-rangedate-picker/issues/74 to try gain the attention of the project owners. Lets see if they respond-- perhaps we can upgrade you to a contributor or fork the project and merge people's PRs :).