captain icon indicating copy to clipboard operation
captain copied to clipboard

feat: assistant virtual list

Open pixelass opened this issue 1 year ago • 1 comments

Motivation

adds virtual scrolling to prevent laggy scrolling on chats with long history

Known issues:

  • Will always scroll to bottom when generationg. I could not find a way to implement the threshold of 200px
  • Not a native scroll, therefore has several a11y issues (no keyboard scroll)

Issues closed

pixelass avatar May 22 '24 21:05 pixelass

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9b5f1181b0daed10d015f42df6083db35139f109) 2130 2002 93.99%
Head commit (5301c5a4b7001b3bdbebf14845c0aa7a6ba23976) 2130 (+0) 2002 (+0) 93.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#304) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

codacy-production[bot] avatar May 22 '24 21:05 codacy-production[bot]

closing. Might revisit when we run into performance issues of long chats. This solution has too many drawbacks to be justified.

pixelass avatar May 27 '24 21:05 pixelass