Brian Leonard

Results 80 comments of Brian Leonard

Yes, that sounds good. I would allow them to set that one and use that. If we use the above as a default, though, it's pretty still that it would...

Sorry, not every deploy. I read it wrong. But when the a config changes. I still think `default` is a nice idea and gives the expected behavior without a hash...

release candidate: `gem 'makara', git: 'https://github.com/taskrabbit/makara.git', tag:'v0.4.0'`

Looks good to me. Is there a use case where someone wouldn't want us to mess with this?

It should pas through the normal `pg` ones through to the Postgres adapter. ``` production: adapter: 'pg_makara' database: 'MyAppProduction' # any other standard AR configurations # add a makara subconfig...

in `connection_wrapper` i see this ``` ruby def _makara_blacklist! @connection.disconnect! if @connection @connection = nil @blacklisted_until = Time.now.to_i + @config[:blacklist_duration] end ``` that suggests if you set blacklist_duration to zero...

if I'm reading it right, if we never raised `BlacklistConnection` that would also be like it was just a "normal" errors (you'd see the original) maybe `gracefully` in https://github.com/taskrabbit/makara/blob/master/lib/makara/error_handler.rb should...

we do log the error. ``` ::Makara::Logging::Logger.log("[Makara] Gracefully handling: #{err}") ``` You might have to set up the logger to your Rails one. Something like this: ``` Makara::Logging::Logger.logger = Rails.logger...

I'm going to combine this with this one (https://github.com/taskrabbit/makara/issues/78) -- I think they are both saying that master is special and especially if there is only one, there is something...

the `/A` means "start of string" - so there's probably a new regex (or set of them) to write to handle the `with` case.