Akash Hamirwasia
Akash Hamirwasia
Got it, this workflow makes sense. But it also requires us to have some testing setup in place which is missing right now 😅. It would better if we can...
Let me create a new issue for testing setup. This issue was for discussing GitHub workflows.
The issue for unit testing setup has been created here – #19. It also has some points on why Vitest is preferred for this project.
@vr-varad Sure, you can work on it!
@ddelange Not yet, will check it tomorrow. By the way, are you done with the changes for this PR?
@ddelange I've pushed some fixes to your code and I can now see the multi-file(and single-file) download to work. Do test it from your end too if it is working...
@Mounayer Thanks for taking this up and preparing such a nice PR description! I don't recall what the context of the original issue was (which is a miss from my...
I think we can remove the error modal for local peers. I thought about showing it at the place where local peers are getting rendered, but I don't think it'll...
Can we catch the errors from this line too? https://github.com/blenderskool/blaze/blob/e9279201047cf06a24487d7cd0bc5a42bb5a3cb6/client/src/routes/App/FileTransfer/FileTransfer.js#L240 `new WebSocket()` throws errors related to insecure connections on secure sites, etc. and it would be good if we can...
I'll maybe add a better example for this in the docs, but for the meantime you can refer to the styles applied in the code blocks on https://react-code-block.netlify.app/usage page.