New version fails to build on ARMv8
This issue and its resolution have been described in this thread: https://inbox.sourceware.org/gcc-help/CAH8yC8=0D8DrgZjmo-og1k=-8B3R6AWaM_mdUh=fTTOTKJuORQ@mail.gmail.com/T/ and involve a one line change in the CMakeLists.txt file. Should I submit a pull request or wait for somebody else to fix it?
What is the GCC version that fails here?
What is the GCC version that fails here?
g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Interesting - I was under the impression that +crypto was deprecated and replaced with the two additional options, which maps AArch64 ISA Features closer to compiler flags. For example this is how clang works.
I would need to kinda review this as I don't understand why it doesn't work with GCC, or perhaps, does it work with a more recent GCC?
Haven't tried to use it with the more recent gcc version. Stuck with the older one for now.
i experienced the same error with gcc 10 on debian 11.
the gcc docs https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html says: ‘aes’ Enable the Armv8-a aes and pmull crypto extension. This also enables Advanced SIMD instructions.
‘crc’ Enable CRC extension. This is on by default for -march=armv8.1-a.
‘crypto’ Enable Crypto extension. This also enables Advanced SIMD and floating-point instructions.
Feature crypto implies aes, sha2, and simd, which implies fp.
there is no mention of any deprecation
This needs a CI repro first - since GH now allows AArch64 linux VMs I think it should be easier to repro.
This should be fixed in master, thanks!
BTW only old GCCs have this issue - new GCC compilers build properly even without the fix.