dtm icon indicating copy to clipboard operation
dtm copied to clipboard

likelihood bounds for heldout set in time mode are always 0.0

Open muellermarkus opened this issue 3 years ago • 0 comments

For any given heldout set, the heldout_post.dat file shows a 0.0 likelihood bound for each document. The issue appears to stem from the code referenced below. Instead of saving the previously calculated likelihood variable to the table, the log_likelihood from the doc_t struct is saved, which is initialised to 0.0 in data.c.

https://github.com/blei-lab/dtm/blob/810d9abb5eda13a486f3fb283383981a2d7aeb66/dtm/main.c#L277

To solve this problem, I propose to simply use table[t][d] = likelihood;.

muellermarkus avatar Aug 16 '21 14:08 muellermarkus