Ben Leggett

Results 391 comments of Ben Leggett

> @bleggett Thanks for the PR. > > My apologies if this has already been mentioned and buried in this thread but could you write a description of the changes...

Resynced w/main - I'm good if you all are.

> Looks basically good; I'd like to see it split in to a few more commits. One for the new API, one to move all test code, one for trivial...

> @bleggett Thanks for picking this back up, I fell sick a few weeks ago and didn't manage to continue. > > I'm taking another look at this now, there's...

> @bleggett Already done, take a look at the current `pkg/datapath/linux/devices_controller.go`. > > Looks like CI is still failing even after fixing `makeNetlinkFuncs` in `ci-runtime`. Do you have any cycles...

Can I get someone to `/test`? I can't repro any unit test failures vis a vis `main` but need to check the conformance suites.

@ti-mo et al - tests seem good to me locally, and the conformance tests are passing now. I note that one each of the gateway API and ginkgo subtests are...

I am going to take a stab modifying the plugins to support this shortly, to see how much churn it might introduce.

> Thank you @bleggett for opening this issue. While we were discussing this today in our maintainers sync, we thought that it would be a good idea if you can...

https://docs.google.com/document/d/1A1oQHuR6z3bvQtXN17r2EwBr5lazGGPbUPkxoURAAh4/edit doc (mostly a codification of above) that I intend to run thru there