Ben Leggett
Ben Leggett
> Why not just set `all:debug` if you want everything? That will work if you explicitly set `cni.logLevel` directly/by itself yep. And since `cni.logLevel` currently ignores the global setting, that's...
@yas8say Sorry! I ended up fixing this in https://github.com/istio/istio/pull/51074 myself because I was already working in the area. TYVM for volunteering!
> Currently, this can only be done by reading, editing, and re-writing the configuration file. This is fragile, since the file is nominally "owned" by one network provider, but edited...
Took a stab at a quick spec update to add this in #1052 (looking ahead to 1.2+) - mostly to clarify what a spec-based approach would look like.
Back from break, should be good for review. Still working on test failures.
@ti-mo tests are good, resynced against `main`, PTAL.
@derailed tyvm, comments addressed. EDIT: Also forgot to stub for non-linux build.
@derailed @ti-mo courteous RFR bump, since everything is addressed/passing and this otherwise seems G2G on my end.
The PR https://github.com/cilium/cilium/pull/29360 added a new helper function `ReplaceMacAddressWithLinkName` to the old `netns.go` - like most of the helper functions that were already in the old version that I have...
`go mod tidy && go mod vendor` come back clean with no git status for me, so not sure what's up with that.