ngx-uploader
ngx-uploader copied to clipboard
feat: Handling Failed Uploads
Adding the ability to handle failed uploads. This is done by adding the 'load' event on the XMLHttpRequrest and looking for a status < 400. Instead of bubbling an error I went with the approach of setting the file UploadStatus to Failed (new enum value) and pushing it in the observable state with a type of 'failed'.
I felt this would be the least disruptive and most simple to implement.
thanks for your PR. can you please amend commit message to follow guidelines and update readme for documentation.
Can you point me to the guidelines? Also, I have updated the sample application to show usage. There was no reference to documentation that I could find.
please check https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit so we can generate changelog with new feature.
I amended the commit message. Is it ok?
please do
git rebase -i HEAD~3
mark second and third commit with s
and leave commit message feat: add handling of failed uploads
then save.
git push origin master -f
then please let me know.
also, please update version in package.json
so we can publish new version to npm
.
Bump to minor or patch? 7.2.0 or 7.1.1
to minor.
All requested changes done. :)
Hi, this is not in production yet, right? Thx!
Hi, this is not in production yet, right? Thx!
Not that I am aware of. PR is still open.
@jkuri can u please merge this pr? This is important feature. Without this - uploader show UPLOAD DONE when server response with error
bump