Possible improvment for the SMPlayer cleaner, but welcome?

[Tobias-B-Besemer]

I found a "strange" bug in SMPlayer. I reported it now here: https://sourceforge.net/p/smplayer/bugs/937/ In short said: There are a combination of issues in SMPlayer that cascaded lock files get created, no more delete and make SMPlayer "un-usable" this way. I would be able to improve the SMPlayer cleaner in this way, that this lock files gets deleted (it's trash) and SMPlayer will work normal, again. My problem is the following: It's normally a bug in SMPlayer and if this issue would exist, there were no need to delete this files! So it feels a bit like "cleaning" a bug, what normally isn't the job of BB... ...on the other side it's a trash file! A job for BB! And: A bug fix will land in a future version of SMPlayer (earliest 20.04!) and then the user have to install the update and then the update hopeful fix a broken config/install... With a cleaner we would have a immediate solution to help users now, without any update of SMPlayer needed! So the question is: If I add some lines to the cleaner to delete this trashy lock files, @az0 would you accept and check in the PR ???

[az0]

Is there a reason to keep the lock file while the SMPlayer process is running, or should it always be deleted?

[Tobias-B-Besemer]

I don't know if we already check if EXE is running, but if not, I guess I should at least implement this. If running check is implemented, lock file doesn't get deleted as long SMPlayer is open.

[Tobias-B-Besemer]

I added 'running type="exe"' here: https://github.com/az0/cleanerml/pull/271