meteor-casperjs icon indicating copy to clipboard operation
meteor-casperjs copied to clipboard

Make the package compatible with velocity:[email protected]

Open ghost opened this issue 10 years ago • 8 comments
trafficstars

Please read my comment regarding the breaking change in the new velocity:core release: https://github.com/meteor-velocity/velocity/issues/96#issuecomment-90531211

Thanks

ghost avatar Apr 07 '15 12:04 ghost

@Sanjo Thanks. I think the code base of this package is very outdated by now anyway. Unfortunately I'm unable to further maintain the code and I'm thinking about deleting the package from the atmosphere repository.

blazer82 avatar Apr 07 '15 15:04 blazer82

Based on your current dependency version on velocity:core it should still work well with the latest velocity:core. Besides from this breaking change we haven't done any breaking changes.

I think its a good idea to keep this issue open so someone else can make it compatible, if someone is interested in this.

ghost avatar Apr 07 '15 15:04 ghost

@blazer82 This package doesn't seem outdated to me! After applying the change @Sanjo recommended (PR #10), it's working great again.

If you aren't interested in maintaining it further, I'd be happy to carry the torch as best I can for a while (you merged #5 from me back in January).

logankoester avatar Apr 30 '15 05:04 logankoester

@logankoester I'd be very happy to see the code being maintained further, thank you! I suggest I'm gonna mention your fork as the official successor in the readme file, and as soon as you are ready to publish your version of the package to the atmosphere repo I'm going to remove mine, what do you think?

blazer82 avatar May 04 '15 07:05 blazer82

@logankoester you should get in touch if you'd like to join us on the Thursday Velocity calls where framework authors get together and drive Velocity forward.

SamHatoum avatar May 04 '15 16:05 SamHatoum

@blazer82 Works for me! Thank you. I've already published ldk:casperjs.

logankoester avatar May 04 '15 16:05 logankoester

@samhatoum Alright, tell me more :-)

logankoester avatar May 04 '15 16:05 logankoester

@logankoester email sent!

SamHatoum avatar May 04 '15 16:05 SamHatoum