Herbie icon indicating copy to clipboard operation
Herbie copied to clipboard
verified publisher icon blaylockbk

erroneous overwrite param in find_grib()

Open BANANAPEEL202 opened this issue 5 months ago • 2 comments

calling download(overwrite=True) lead to the following broken code branch Screenshot 2025-08-02 at 3 12 36 PM

BANANAPEEL202 avatar Aug 02 '25 22:08 BANANAPEEL202

Thanks for the PR! I really appreciate it. I think you're right with this change, but I need to think about this one for a minute. I'm having a hard time remembering if that was there for a purpose, or if I just missed something during a refactor.

blaylockbk avatar Aug 09 '25 15:08 blaylockbk

Thanks! Yea, would definitely appreciate a more thorough review. I don't have a complete understanding of the codebase so not entirely sure if this might affect something else.

And as a side note, Herbie has been great to work with!

BANANAPEEL202 avatar Aug 09 '25 17:08 BANANAPEEL202