Herbie icon indicating copy to clipboard operation
Herbie copied to clipboard

Rename `searchString` to just `search` or `filter`

Open blaylockbk opened this issue 2 years ago • 2 comments

I think I'd prefer using the argument name search instead of searchString.

# Current
Herbie('2023-01-01').xarray(searchString="TMP:2 m")

# proposed
Herbie('2023-01-01').xarray(search="TMP:2 m")

# or 
Herbie('2023-01-01').xarray(filter="TMP:2 m")

blaylockbk avatar Oct 15 '23 04:10 blaylockbk

I actually am liking the word "filter" here instead. I'll see if anyone else has comments on this.

blaylockbk avatar Apr 02 '24 22:04 blaylockbk

oh, filter is a built-in function. Can't use that.

I'll just replace searchString with search.

The reason is becuase search is really a regex search, not a string exact match.

blaylockbk avatar Apr 17 '24 04:04 blaylockbk