openblas-src icon indicating copy to clipboard operation
openblas-src copied to clipboard

[openblas-build] Don't try to run openblas tests when cross compiling

Open ivan-aksamentov opened this issue 11 months ago • 0 comments

This configuration runs make targets all (explicit) and libs (coming from self.make_args()), which both try to run openblas tests from test/ and utest/ directories compiled for a foreign architecture on a host machine:

https://github.com/blas-lapack-rs/openblas-src/blob/e1fd7951dc3c2a51b4c73befff23787f915b1fff/openblas-build/src/build.rs#L493-L495

Which causes errors, because the resulting test executable cannot be ran on a host arch.

It also passes unrelated env vars - whether you cross-compiling or not, while preventing users from setting TARGET for example.

Instead, only the make target shared (confusingly named) needs to run. Users should be in control of which env vars they want to set during cross-compilation, there is no point to pick and rename the vars in this crate - it only brings confusion and bugs.

This issue makes it impossible to cross-compile the library (combined with other defects), and therefore it makes it impossible to use math libraries which rely on this crate in a production environment.

ivan-aksamentov avatar Feb 27 '24 16:02 ivan-aksamentov