Pierre Blanchard

Results 101 comments of Pierre Blanchard

In light of the recent OS-es additions to GHA, we are going to close this issue. A dedicated issue (#544) was raised to allow testing libm and quad with MinGW/MSYS2,...

Hello! I think I understand the issue/suggested solution, although it did not sound extremely clear. I don't really understand how this works as is. While the change to CMakeLists.txt seems...

Hello @xuhancn! I'm looking into now. I would prefer a slightly different approach though but I will look at how feasible that is.

Right, let me know if I'm missing something but I believe we don't have to rename the variable to get the behaviour you are expecting. Could you try defining the...

First, what I was getting at is not simply moving back to using BUILD_SHARED_LIBS but also making sure save/add_subdirectory/restore occurs inside a function (or at least a scope) so it...

Not sure I understand. I don't think this will solve the issue, but feel fee to try. I was picturing defining a function encapsulating everything at this link https://github.com/pytorch/pytorch/blob/cee16353db384dd33a4804f9f26829cacfcfbab7/aten/src/ATen/CMakeLists.txt#L442-L478. Then...

We have no issue with people using SLEEF as a submodule, if anything that is probably the preferred approach and we provide examples for that. > As a submodule, sleef...

Hi! Sorry, I did not find time to test before. But I just did it on MSYS2 (Unix-like Windows environment) and as expected I get static libs when setting `BUILD_SHARED_LIBS=OFF`...

> [blapie_example_output.txt](https://github.com/shibatch/sleef/files/14483892/blapie_example_output.txt) I attached the all log to you for analysis. Btw I do not see the messages I added to the CMakeLists.txt in your log. It should show this,...

Ok, right in this case even the config log seems wrong ``` -- Building shared libs : ON ``` although the top-level CMakeLists.txt has ``` set(BUILD_SHARED_LIBS OFF CACHE BOOL "Build...