node-zendesk icon indicating copy to clipboard operation
node-zendesk copied to clipboard

Typescript Support

Open sebastiansandqvist opened this issue 6 years ago • 7 comments

Wondering if type definitions could be added so that Typescript users can easily use the ZenDesk API

sebastiansandqvist avatar Feb 17 '19 22:02 sebastiansandqvist

@types/node-zendesk does exist but it is not complete, e.g. the type of the second and third arguments of ZendeskCallback is specified as unknown in its uses, giving errors when trying to access its properties.

Pwuts avatar Apr 04 '20 09:04 Pwuts

@blakmatrix any comment on why you've closed this issue?

Pwuts avatar Jun 17 '20 13:06 Pwuts

Cowboy Theatrics shrug what is "@types/node-zendesk" ? I'm doing my best to get back into trying to maintain this.

blakmatrix avatar Jun 18 '20 03:06 blakmatrix

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f667351f064837dec421df5abadae50c5a0ba698/types/node-zendesk/node-zendesk-tests.ts https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f667351f064837dec421df5abadae50c5a0ba698/types/node-zendesk/index.d.ts https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f667351f064837dec421df5abadae50c5a0ba698/types/node-zendesk/tsconfig.json

blakmatrix avatar Jun 18 '20 06:06 blakmatrix

#276

blakmatrix avatar Jun 28 '20 02:06 blakmatrix

Hi, I am just replying here since you've left the issue open, and I'd like to help. Is there any particular process you prefer? I have never submitted updates to DefinitelyTyped but would like to share any types that I need to add as I'm working with the module. In particular, I'll be working with macros and help center api, and the methods are implemented but missing from @types/node-zendesk. I already started a fork: https://github.com/mattcasey/DefinitelyTyped/tree/node-zendesk. Do you mind if I just submit all my changes at once when I've finished our first iteration (I'm going to need maybe 5-6 methods?)?

mattcasey avatar Mar 16 '21 18:03 mattcasey

Hello I have open a issue right there : https://github.com/blakmatrix/node-zendesk/issues/331 It's seems @types/node-zendesk does not match your code. Also your project does not provide pagination information ? Object are destructed and does not match zendesk api I found. Please tell me if it's normal or maybe my version don't match. Thank you for your help

stormsa avatar Feb 21 '22 17:02 stormsa