TransitionKit
TransitionKit copied to clipboard
Carthage support
- Added framework and test schemes for each supported platform.
- Made the schemes Shared for Carthage support.
- Deintegrated CocoaPods.
- Added the Kiwi dependency as a git submodule.
- Bumped the pod version.
- Raised the minimum deployment version to 6.0 to support bitcode.
Nice job getting the tests working!
However, rather than include the Pods directory in the repository, I would suggest instead that you create Cartfile.private
and add the dependencies that are in the Podfile there.
Thanks @weissazool!
I've made those changes but for some reason Travis CI doesn't use the proper .travis.yml config for the latest commits but you can check the status of the build for my fork here: https://travis-ci.org/arturgrigor/TransitionKit/builds/233918533.
@arturgrigor Great! I have a question, though.
If you remove the Podfile and the Podfile.lock, won't it no longer be possible to add this framework via Cocoapods, since it won't be able to fetch its dependencies?
Also, the Carthage directory should probably be added to .gitignore
.
@weissazool no, removing the Podfile doesn't affect that at all because the installation uses the TransitionKit.podspec
in which you define the dependencies. The Podfile is just for building the project locally but as long as you got the Carthage frameworks in place you no longer need that.
Yeah, I guess you're right with the .gitignore
file.
@arturgrigor I see. But for any existing users, there's no guarantee that they will have Carthage. Since the primary method of integration up until now has been Cocoapods, it's quite likely that they have that. My concern is that this would break this part of the readme for any current users of this framework.
@weissazool That wouldn't be affected at all because when you install this framework using CocoaPods it uses the TransitionKit.podspec
file which already exists. The Podfile
needs to be there only if you want to build this particular framework locally in order to contribute to it. So as you can see these are 2 different people, an app developer and a framework developer.
But don't worry because I did a few changes and I added the Podfile
and Podfile.lock
files back.
@blakewatters can you please take a look at this small PR?
The whole purpose of this PR is to add Carthage support to this project and in order to do so I have followed the setup from AlamofireImage for building the project and linking the dependencies.