Blake Pettersson

Results 233 comments of Blake Pettersson

@mattfarina in the case of `toYaml` it's pretty straightforward. My only concern is that this is inconsistent with how it's done with the existing tojson function. Would it make sense...

Hi @js3692! Could you add unit tests for this? And can you add docs / comments in regards to this (similar to what you did in #17217)?

Hi @js3692! Sorry about that - I missed that this was just a UI change (there definitely should be UI tests IMO, but that's another matter and not pertaining to...

Do we really want to automatically propagate all Application labels to application manifests? Why can't source Kustomizations or Helm values be used for those purposes? Could not ApplicationSet [templating](https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/GoTemplate/) not...

Something which I think could be interesting would be to selectively apply labels by `Kind` and `Group`, something like ```yaml managedResourceMetadata: labels: foo-label: value: bar any: - resources: names: -...

@crenshaw-dev it seems like #14648 could work for this. Could this be combined with Helm charts being rendered with `helm template`? Or is this something that would need #12508 (if...

For Helm sources, #16749 seems like it could be a viable alternative

We've been running this in our environment and it works fine there. @JorTurFer do you have any opinions regarding the implementation?

> I think a better representation of this would be if the application state remains healthy, but we show only scaledObject state as suspended. I'm not sure if this is...