eclipse-lisp icon indicating copy to clipboard operation
eclipse-lisp copied to clipboard

Off-by-one-error in tag initialization

Open jasom opened this issue 9 years ago • 1 comments

This line loops from 1 to 8; the array it is initializing is indexed from 0-7; The ommision of 0 is probably correct, as all zeros is the data tag. I'm not sure if the bug is the inclusion of 8 in the loop, or the size of the cl_POINTER_TAGGED_FOO arrays should be 1 larger, so I didn't make a PR.

https://github.com/blakemcbride/eclipse-lisp/blob/master/c/interface.c#L3609

jasom avatar Apr 15 '15 17:04 jasom

Thank you very much for the report. As mentioned in ISSUES.txt, the system does have some problems that shouldn't be too bad for someone with a bit of time.

On Wed, Apr 15, 2015 at 12:19 PM, Jason Miller [email protected] wrote:

This line loops from 1 to 8; the array it is initializing is indexed from 0-7; The ommision of 0 is probably correct, as all zeros is the data tag. I'm not sure if the bug is the inclusion of 8 in the loop, or the size of the cl_POINTER_TAGGED_FOO arrays should be 1 larger, so I didn't make a PR.

https://github.com/blakemcbride/eclipse-lisp/blob/master/c/interface.c#L3609

— Reply to this email directly or view it on GitHub https://github.com/blakemcbride/eclipse-lisp/issues/1.

blakemcbride avatar Apr 15 '15 19:04 blakemcbride