javascript-stringify icon indicating copy to clipboard operation
javascript-stringify copied to clipboard

Published 20 hours ago • verified publisher icon blakeembrey

Support for Deno?

Open shah opened this issue 3 years ago • 2 comments

Hi there, this is a cool library but does not have built-in support for Deno. I've forked the repo and made minor changes to get it to work on Deno. Any interest in rolling in Deno support to your master branch?

If you're interested, Denoify is a tool that could make it easier?

shah avatar Jul 17 '20 21:07 shah

Happy to accept a PR. I think all that’s needed is adding extensions to imports right?

blakeembrey avatar Jul 18 '20 00:07 blakeembrey

Yes @blakeembrey from the version I tested adding *.ts extensions is all that's required. I only need Deno support so that's all I need but I suspect you'd like your module to remain ready for NodeJS, the browser, or Deno so that's why I recommended Denoify. Also, I haven't been able to run tests in Deno yet (I haven't had a chance to research which libraries you're using) but that would be handy: Deno has built-in testing infrastructure and tooling.

shah avatar Jul 18 '20 10:07 shah