frigate
frigate copied to clipboard
blakeblackshear
optimize output_frame_resize
Deploy Preview for frigate-docs canceled.
| Name | Link |
|---|---|
| Latest commit | ebcdb63aac21b1be627b5338a0576553f426268e |
| Latest deploy log | https://app.netlify.com/sites/frigate-docs/deploys/6563d8d74fee5d0008eed1f6 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
I have ~x2 performance improvement with this modifications
to be clear, that means ~ one half CPU usage? I'll try this in the morning and see how it goes in my setup
to be clear, that means ~ one half CPU usage? I'll try this in the morning and see how it goes in my setup
that means ~25% CPU utilisation by frigate.output process before, and ~12% after
in the morning
so relative... :-)
So I ended up trying this now, wanted to clarify the above because I think https://github.com/blakeblackshear/frigate/issues/6853 got steered into the direction of the motion detection CPU usage which is separate from frigate.output. My motion detection CPU usage is unaffected by this PR.
In any case, this PR brought the frigate.output CPU usage in my setup from 20% of to 13% in top. I am just wondering if the openblas changes have affect that at all or if it is just the other changes, in which case maybe the openblas changes aren't needed?
maybe the openblas changes aren't needed?
Given in mind my mistake in pushed Dockerfile (openblas and env vars were installed only in wheels step, but not in the final step) and your feedback on performance improvements - apparently, openblas does not significantly affect the result :)
My motion detection CPU usage is unaffected by this PR.
test within latest commit (7ee53df)
This has caused my CPU usage to go up for each camera detect process by ~ 2 - 3 %
Might be better for this PR to keep things focused on the frame_resize improvements which reduced CPU usage by frigate.output and potentially work on other changes in a separate PR
Might be better for this PR to keep things focused on the frame_resize improvements which reduced CPU usage by frigate.output and potentially work on other changes in a separate PR
You suggest rollback this PR to 4f9cf22, and move other commits to separate PR?
Might be better for this PR to keep things focused on the frame_resize improvements which reduced CPU usage by frigate.output and potentially work on other changes in a separate PR
You suggest rollback this PR to 4f9cf22, and move other commits to separate PR?
Based on previous conversation I would also suggest removing openblas, but yeah I think it makes sense to keep it separate since the frigate.output is separate from the motion detector
Might be better for this PR to keep things focused on the frame_resize improvements which reduced CPU usage by frigate.output and potentially work on other changes in a separate PR
You suggest rollback this PR to 4f9cf22, and move other commits to separate PR?
Based on previous conversation I would also suggest removing openblas, but yeah I think it makes sense to keep it separate since the frigate.output is separate from the motion detector
What do you think about create configuration option for interpolation algorithm, used in internal calculations?
I think it is too advanced for most users to understand / our docs to explain which one to use. I'm also not sure in which cases a user would want to change that
this decreased my output process CPU usage by at least half its previous usage. good work!
@blakeblackshear this PR is related to #6986 I didn't test them separately