frigate icon indicating copy to clipboard operation
frigate copied to clipboard

YOLOX support for OpenVINO Detector

Open aeozyalcin opened this issue 2 years ago • 4 comments

This PR is to add YOLOX support for the newly added OpenVINO detector. I added a new config parameter called model_type, which is ssd by default to match the default ssdlite_mobilenet_v2 model that comes with Frigate. Users can change this to yolox to use a yolox model instead. After the changes, I confirmed that the existing SSD OpenVINO support still works.

I have also added a text into the documents explaining how to use a yolox model, and what the limitations are.

aeozyalcin avatar Jan 29 '23 07:01 aeozyalcin

Deploy Preview for frigate-docs canceled.

Name Link
Latest commit cf70808c774b75762661267f46debda8c56c416c
Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63db2c1af4ea67000823a26b

netlify[bot] avatar Jan 29 '23 07:01 netlify[bot]

@NateMeyer FYI

aeozyalcin avatar Jan 29 '23 07:01 aeozyalcin

I'll take a closer look and try to run this later today. Do you have any insight on the differences between this and the yolov4 models?

NateMeyer avatar Jan 29 '23 13:01 NateMeyer

I'll take a closer look and try to run this later today. Do you have any insight on the differences between this and the yolov4 models?

I believe YOLOx is anchorless, while most other YOLO variants have anchors. Post processing the tensors would require a little more math due to anchors. What I have here for YOLOx should be 90% of the way there to support other YOLO variants as well. So maybe in the future, that could be explored.

aeozyalcin avatar Jan 29 '23 17:01 aeozyalcin

@NateMeyer @NickM-27 are there any opens on this before it can be merged?

aeozyalcin avatar Feb 01 '23 18:02 aeozyalcin

@NateMeyer @NickM-27 are there any opens on this before it can be merged?

First need to get checks passing

NickM-27 avatar Feb 01 '23 18:02 NickM-27

Alright 3rd time's the charm. If you can kick off the checks, it would be great.

aeozyalcin avatar Feb 02 '23 03:02 aeozyalcin

All green!

aeozyalcin avatar Feb 02 '23 03:02 aeozyalcin

@NateMeyer @NickM-27 let me know if there are any other opens preventing this merge. Thanks.

aeozyalcin avatar Feb 03 '23 18:02 aeozyalcin