frigate icon indicating copy to clipboard operation
frigate copied to clipboard

Update NVIDIA section

Open LukasMojzis opened this issue 2 years ago • 5 comments

Fix NVIDIA section so it works in the current build of Frigate Fixes #4819

LukasMojzis avatar Dec 31 '22 04:12 LukasMojzis

Deploy Preview for frigate-docs ready!

Name Link
Latest commit 8064b3ba057a43dc70567a21c5150b0e28d96b80
Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/63afbb233ea3a90008c431d6
Deploy Preview https://deploy-preview-4834--frigate-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Dec 31 '22 04:12 netlify[bot]

These docs w the just updated for 0.11 and they work for frigate 0.11. The necessary compose structures is very dependent on the host system, especially for users with multiple nvidia GPUs but also in all cases.

I don't think removing the deploy part is a solution, we used to have less docs on this and for many users the deploy part was required and so it was added for 0.11. There will likely need to be more verbiage around different compose structures and which ones are required in which situations.

NickM-27 avatar Dec 31 '22 04:12 NickM-27

https://github.com/blakeblackshear/frigate/pull/3233 is an example of this which links multiple issues where the current docs structure was required

NickM-27 avatar Dec 31 '22 04:12 NickM-27

Deletion reverted. For me the deploy section passes through the libraries which do not get passed through without it. I agree that removing deploy section is not necessarily needed, but I insist the environment variables are added. There's not much damage and all the difference it can make for many people.

There will likely need to be more verbiage around different compose structures and which ones are required in which situations.

That would be welcome. Especially assuming many people would install clean distro and would need more info as to which packages are needed for which distros.

LukasMojzis avatar Dec 31 '22 04:12 LukasMojzis

The environment variables are now set in the dockerfile directly, so they won't need to be set in the compose file: https://github.com/blakeblackshear/frigate/blob/dev/Dockerfile#L210-L212

If you want to update this PR with other variations of compose files, you can. Otherwise, we should close this.

blakeblackshear avatar Dec 31 '22 15:12 blakeblackshear