linked-data.syntaxes icon indicating copy to clipboard operation
linked-data.syntaxes copied to clipboard

Request: support for colour scheme

Open ncarboni opened this issue 5 years ago • 7 comments

Love the package but not a fan of dark theme. I was wonder if you would consider supporting in the future the Soda colour scheme.

ncarboni avatar Apr 30 '19 08:04 ncarboni

The package actually ships with a light color scheme as well (although it is still in beta).

Screen Shot 2019-04-30 at 10 48 54 AM

If you are a big fan of the Soda color scheme, maybe you'd be interested in submitting a PR for integrating a similar one into this package? The schemes in the package right now are actually generated using a simple starting palette of 10 colors and then shifting the shades by some amount for each scope; see here.

blake-regalia avatar Apr 30 '19 17:04 blake-regalia

The package actually ships with a light color scheme as well (although it is still in beta).

I tried to select it from the colour scheme menu, but, unfortunately, every time I set the syntax of a file to Turtle it comes back to use "macarom dark" colour scheme. That being said, the light colour scheme seems nice. I would happily use it if I manage to fix the erratic behaviour

ncarboni avatar May 01 '19 08:05 ncarboni

@ncarboni I added a section to the README that documents how to override the default color scheme. I hope this helps!

blake-regalia avatar May 01 '19 22:05 blake-regalia

@ncarboni I added a section to the README that documents how to override the default color scheme. I hope this helps!

Thank you! It definitively helped!

If you are a big fan of the Soda color scheme, maybe you'd be interested in submitting a PR for integrating a similar one into this package? The schemes in the package right now are actually generated using a simple starting palette of 10 colors and then shifting the shades by some amount for each scope; see here.

Thanks for the pointer, I will try to work on it!

ncarboni avatar May 02 '19 05:05 ncarboni

Could you please refrain from forcing a color scheme that users cannot reset (ie one can't set it to null to inherit the scheme used for the rest of the editor)?

berezovskyi avatar Aug 07 '19 00:08 berezovskyi

@berezovskyi The whole point of this package is to provide rich syntax highlighting which requires custom color schemes. You are welcome to override the color scheme in your settings file but you might as well use one of the existing sparql or turtle packages instead if you are not interested in the features of this package anyway.

blake-regalia avatar Aug 07 '19 01:08 blake-regalia

I see! Honestly, I only needed NTriples support. And let me apologise for not thanking you enough for your great work, Blake!

berezovskyi avatar Aug 08 '19 13:08 berezovskyi