acelink
acelink copied to clipboard
Support for Ubuntu 22 Docker Image (or if it's worth it)
Firstly, thanks for creating this software @blaise-io and the other maintainers. It works really nicely and I appreciate the time you've put into it 🙂
Background
I'm creating this issue to ask if it's worth upgrading the base image to Ubuntu 22.
To my knowledge, Ubuntu 18 "Jammy" reached EOL in May 2023 meaning there will no longer be updates for it (although I'm not sure if their support lifecycle is different from their provided Docker images).
My initial thoughts were that with this being a Docker image that very much interacts with the wider internet, it probably makes sense that its base OS be one that's modern and receiving security updates. However I'm not an expert, and if the likely risk is minimal (e.g. if the main vulnerability would be the closed, ageing AceStream binaries, which we can do nothing about), I'd be happy to educated.
Ubuntu 22 Based Dockerfile
In that vein, I created a modified Dockerfile which I've got working smoothly with Ubuntu 22.
https://github.com/blaise-io/acelink/compare/master...TurtleRanking:acelink:ubuntu22support
In brief summary I made these changes
- Changed base image (duh!)
- Added the command
export DEBIAN_FRONTEND=noninteractive
, and-yq
options to all apt commands, to ensure the quite talkative newer version of Ubuntu doesn't prompt for user interaction - Added
apt upgrade
andapt autoremove
commands. Quite possibly unnecessary, but they seemed like nice things to have. - Removed the
python-[Python 2 package name]
Ubuntu packages, as they're no longer supported and replaced them withpip
installs - Explicitly installed libssl1.1 (which AceStream seems to need) with a rather hacky method
It does have quite a larger size than the current image (~200ish vs 600ish).
Conclusion
If there's no desire to change the base image for any reason, that's totally fine!
Or if a change is planned but there's a different/better way to go with it than my Dockerfile, that's fine, too, I just thought I'd share my one in case it could be helpful
All the best! TurtleRanking