jquery.animateSprite icon indicating copy to clipboard operation
jquery.animateSprite copied to clipboard

Stop not working

Open mumbaimerijaan opened this issue 7 years ago • 4 comments

Stop not working... When I checked I found that all timeouts are not removed, hence when reloading the page in the iframe I am getting an error.

To solve this, I passed the timeout id to the function called in setTimeout, and then cleared the timeout promptly. Please make this change to the original code, so that others will be benefited.

mumbaimerijaan avatar Dec 05 '17 15:12 mumbaimerijaan

Hi @mumbaimerijaan , thanks for opening the issue.

Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please?

Thanks!

blaiprat avatar Dec 06 '17 13:12 blaiprat

Sorry am new to github.. what's a PR?

Regards, Sachin

On Dec 6, 2017 7:29 PM, "Blai Pratdesaba" [email protected] wrote:

Hi @mumbaimerijaan https://github.com/mumbaimerijaan , thanks for opening the issue.

Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please?

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blaiprat/jquery.animateSprite/issues/14#issuecomment-349647460, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIiqrtr4Qvjc5lbI9iyy6Mhz_FfR6RHks5s9p2lgaJpZM4Q2hRt .

mumbaimerijaan avatar Dec 09 '17 14:12 mumbaimerijaan

Hey ! Thank you for your script ! Loop and autoplay are not working for me, do you know how to solve this please ?

Regards.

CorentinVv avatar Sep 13 '18 13:09 CorentinVv

Sorry am new to github.. what's a PR? Regards, Sachin On Dec 6, 2017 7:29 PM, "Blai Pratdesaba" @.***> wrote: Hi @mumbaimerijaan https://github.com/mumbaimerijaan , thanks for opening the issue. Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIiqrtr4Qvjc5lbI9iyy6Mhz_FfR6RHks5s9p2lgaJpZM4Q2hRt .

PR is a pull request

CorentinVv avatar Sep 13 '18 13:09 CorentinVv