Finish testing instrumentation refactoring

Open blaggacao opened this issue 4 years ago • 1 comments

This.

https://github.com/blaggacao/kubenix/commit/bbc5e3d477d453a05d5c7de1f9ec8446aa7742cb (original work by @offlinehacker)
https://github.com/blaggacao/kubenix/commit/1bd3fe4d4e6bcde6345968a9554934b6b0bac00f (some best guess-fixups)

Relates to, affects the implementation of:

May 06 '21 21:05 blaggacao

@offlinehacker

Do you remember, what your original vision for the test runtimes was?

I could infer what modules/testing/runtime/local.nix is supposed to do (and how those options should override the docker specific image loading). And I also could infer that modules/testing/runtime/nixos-k8s is probably unfinished.

I had trouble understanding if we must keep those runtimes API compatible with the upstream implementation (e.g. because those produce well known outputs for other tooling). Especially, I wonder if we need to implement equivalents for runTests, makeTests & passMeta for the local runtime.

Maybe a nixos testing expert can provide that data point? :innocent:

May 06 '21 21:05 blaggacao