frappix icon indicating copy to clipboard operation
frappix copied to clipboard
verified publisher icon blaggacao

build: remove drive patches

Open blaggacao opened this issue 1 year ago • 4 comments

Merge once a fully patched version is released.

Depends on:

  • https://github.com/frappe/drive/pull/232 (done)
  • https://github.com/frappe/drive/pull/231 (see comment below)

blaggacao avatar Aug 02 '24 11:08 blaggacao

Had to revert https://github.com/frappe/drive/commit/d3710510f0150b37a618f088b6d9779412797fea1 since it breaks CSS at quite a few places even if the JS built successfully. I'll just do that manually.

uhrjun avatar Aug 06 '24 09:08 uhrjun

@uhrjun Just a quick follow up, how is the release status on these two? I'd be happy to finish off this PR. :smile:

blaggacao avatar Aug 14 '24 10:08 blaggacao

Drive using npm instead of yarn complicated this a bit. I'll take a look at this again over the weekend. Some imports were failing when node_modules was not located within the frontend directory. If this is urgent, feel free to submit a pull request. Otherwise I'll get it done anyway but might take me longer.

uhrjun avatar Aug 16 '24 06:08 uhrjun

@uhrjun Hey Arjun! Were you able to make any progress on the migration to yarn? I'd really like to feature frappe/drive in frappix, soon :smile:

blaggacao avatar Sep 19 '24 09:09 blaggacao