David Arnold
David Arnold
> Fears are nothing more than a state of mind. - Napoleon Hill --- Kindly help move this PR forward. Many thanks from Yours Sincerely!
> What the caterpillar calls the end of the world, the master calls a butterfly. - Richard Bach --- Kindly help move this PR forward. Many thanks from Yours Sincerely!
> Watch your thoughts, they become your words Watch your words, they become your actions Watch your actions, they become your habits Watch your habits, they become your character Watch...
## PR Status Update Upon reflection, I've come to the following conclusion: 1. **Original Intent Unclear**: I'm unable to accurately recall or reconstruct the reasoning behind this PR's creation. 2....
And it's as green as it should be :-) Nice!
@deepeshgarg007 Could you have a look? I have no idea for how many years this was actually broken :eyes:
Test failure prior to fix (revert fix commit and check): ```console ❯ bench run-tests --doctype "Company" ❯ bench run-tests --doctype "Customer" ❯ bench run-tests --module "erpnext.accounts.doctype.loyalty_program.test_loyalty_program" /nix/store/srn5qp23ili0a1gbq2q8v2yqyshqfkws-python3-3.11.9-env/lib/python3.11/site-packages/passlib/utils/__init__.py:854: DeprecationWarning: 'crypt' is...
Since this fixes a long standing misbehaviour, I removed the hotfix to 15, which I think needs more discussion. See inline comments... (tbd)
~work-around: **`skaffold dev/run --wait-for-deletions=false`**~
You're right, me neither. I got one step further, though. As opposed to @philips logs, I get: ```console [...] - unable to recognize "STDIN": no matches for kind "ClusterIssuer" in...