David Arnold
David Arnold
> Where you able to check my comment on https://github.com/frappe/erpnext/pull/41629 ? Hm, I don't see any comment :shrug: But I'm glad that the expectation would have been that there is...
ah! Ok, this explains all :-) Thanks for your comments in this case. It's marked "Pending" which means it's still in a sort of "staging" area and isn't visible to...
https://github.com/frappe/erpnext/pull/42160 is necessary to effectively leverage https://github.com/frappe/frappe/pull/25952 for https://github.com/frappe/payments/pull/53
> Can you have a look at unit tests, if they exist for the core functions touched (not necessarily changed) by this PR? If not, can you please add a...
@NagariaHussain In my preferences, I'd go for a merge of this PR in order to lock-in this step and redirect all efforts of maintaining this PR (read: merge conflicts &...
I wonder if we can move forward on this. I needed to vent a little. Thanks for listenig... I have to be honest and state that I have a strong...
## Cross checks: ### Migratables & Importables: - [x] (1) `rg 'doctype\.communication' | rg 'core'` with no more hit - [x] (2) `rg 'doctype\.notification[^_]' | rg 'email'` with no more...
@barredterra On a sidenote: this is relevant for a single point of capture with regard to documentation requirements for effectively communicated business transactions in their pixel-faithful or pixel-recoverable representation of...
The entity relation of the notification doctype is increasingly becoming a mess, just look at this (still private code) regarding the ad-hoc sender resolver (because some comm mediums puppet while...
I checked after merging `origin/develop` and the conflicting https://github.com/frappe/frappe/pull/24708/files#diff-16395108ee1c35a64cea85aa1de80d19d449a529f0c422a128c3355a1447eb98 was harmless to the above cross check results. The cross check results are still valid and stand.