David Arnold

Results 1203 comments of David Arnold

This shouldn't fall out of scope. If there's no kvm build necessary, it should even build on GitHub actions. The nixos blocktype is implemented here, so any modification to the...

You can check out what the `target` holds in the nixosConfiguration block type, but since the actual nixosConfigurations are located elsewhere in the tree (namely under `.nixosConfiguration`) rather than directly...

Oh that is absolutely so, thank you! I noticed that I forgot to mention that the hidden folders are linux `.dotfolders` . I would like that convention to be honoured...

You're absolutely right! That advice comes just in time! Thank you! Let me review it...

@sagarvora Correct, which is good. But this also the reason for this PR. I couldn't find another way to implement this. Overall, it seems a overly subtle and thus likely...

> Fears are nothing more than a state of mind. - Napoleon Hill --- Kindly help move this PR forward. Many thanks from Yours Sincerely!

What about a (hypothetical, rust like) `frappe.new_doc("My Doc").from("Sales Order", "SAL-ORD-...")` which doesn't raise only if "My Doc" implements `def from_sales_order(self, from_doc)`. Which also implements `so.into("My Doc")`, automatically. EDIT: or rather...

For context on the motivation of this PR, see also: https://github.com/frappe/erpnext/pull/40845#issuecomment-2208612085

Sem Grep Rule violation: ```console erpnext/selling/doctype/sales_order/sales_order.py ❯❯❱ frappe-semgrep-rules.rules.require-permission-decorator-on-conversion-methods '_into_sales_invoice' in 'SalesOrder' crosses doctype boundaries. Explicitly declare its extended security context with @frappe.requires_permission(, ). 744┆ def _into_sales_invoice(self): 745┆ make_sales_invoice(self.name) BLOCKING CODE...