Error when deactivating package

[lexicalunit]

Occurs for me every time the package gets deactivated. Only tested in Atom 1.16.0 beta so far.

Error deactivating package 'python-yapf' TypeError: _ref1.dispose is not a function
    at Object.deactivate (/Users/me/source/atom/atom-python-yapf/lib/index.coffee:56:14)
    at Package.module.exports.Package.deactivate (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:722:20)
    at PackageManager.module.exports.PackageManager.deactivatePackage (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:643:12)
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:347:21
    at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:635:20
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Config.module.exports.Config.emitChangeEvent (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:826:29)
    at Config.module.exports.Config.setRawValue (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:612:19)
    at Config.module.exports.Config.set (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:227:14)
    at Config.module.exports.Config.pushAtKeyPath (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/config.js:361:12)
    at Package.module.exports.Package.disable (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:85:26)
    at PackageManager.module.exports.PackageManager.disablePackage (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:183:16)
    at HTMLButtonElement.enablementButtonClickHandler (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:336:23)

[lexicalunit]

I believe detach() should be called instead of dispose(). From a cursory review I don't see dispose() defined for a View object. It's also worth noting here that space-pen and atom-space-pen-view are deprecated and will soon be removed from Atom entirely. It would probably be worthwhile to refactor the codebase to use manual DOM manipulation before Atom 1.16.0 is released.

[blacktop]

@lexicalunit thank you! You rock so hard!! ❤️

I haven't had time to work this because I have been spending a lot of time trying to learn iOS dev. So if I am going to waste my weekends coding I should at least try to get paid for it? 🤣

I will try and look at this soon hopefully.