story_view icon indicating copy to clipboard operation
story_view copied to clipboard

Fix issue #47 Add support for image or video file path

Open DanialV opened this issue 5 years ago • 2 comments

Hi, I solved this problem for the local project I add another argument file in the story view widget and it works fine in my local project so I decided to send a pull request please check my work thanks.

DanialV avatar May 17 '20 16:05 DanialV

Great work @DanialV . Sorry for the late response. I've looked at your commit. I think the API becomes bloated if we include an explicit parameter file. Instead what we can do is use protocols for the url. That is, specifying url as file://mnt/ex0/downloads/video.mp4 for instance, indicates a file and loads from that directory.

What do you think?

blackmann avatar Jul 22 '20 18:07 blackmann

I am also interested in this. @DanialV I think the API would look better with named constructors like following:

StoryItem.pageLocalImage() 
StoryItem.pageNetworkImage()
StoryItem.pageLocalVideo()
StoryItem.pageNetworkVideo()

umaqs avatar Nov 14 '20 20:11 umaqs

Closing for inactivity

blackmann avatar Nov 30 '23 07:11 blackmann