story_view icon indicating copy to clipboard operation
story_view copied to clipboard

✔️ added preload feature

Open Shadow60539 opened this issue 4 years ago • 4 comments

resolves #108

Concept Followed 👇

concept

Shadow60539 avatar May 29 '21 15:05 Shadow60539

Great work, I'll review this shortly

blackmann avatar Jun 06 '21 13:06 blackmann

Hello @Shadow60539 I have tried to use this PR with the storyexample project... But when I get to the 4th story item (back from the 5th), I am unable to go to the previous (3rd) story item or next (5th) item. I'm just stuck on the 4th.

Looking through the code, I saw some _lock handle... do you think it's necessary to lock the experience while preloading occurs?

blackmann avatar Jun 26 '21 10:06 blackmann

Hello @blackmann

🔒 I wasn't able to come up with any other way other than locking the user. Initially, I thought of displaying the same loading widget when the next or previous video is not initialized yet. However, I used this lock as some sort of a placeholder now.

Even, I'm not completely happy with this lock 🔒

Another better way to tackle this is to remove this lock parameter and display the first frame using chewie with a loading widget but in order to get the first frame, I think we the video player controller should be initialized first.

Shadow60539 avatar Jun 26 '21 10:06 Shadow60539

Hello did you guys find a solution here? :)

ssaeed003 avatar Jan 27 '22 00:01 ssaeed003