recurly icon indicating copy to clipboard operation
recurly copied to clipboard

support for add_on_usage

Open ordo-viddler opened this issue 6 years ago • 4 comments

Here is my attempt to implement add_on_usage: https://dev.recurly.com/docs/usage-record-object.

Couple things I would like you to be sure to check:

  1. naming - english is not my native, so if you find anything should be named different, let me know
  2. I introduced NullFloat as it seems to be necessary in one of usage field
  3. I changed PagerOptions query field to be public (Query) - add on usage record utilizies some non-standard query parameters. If this should be done different way, please let me know and I'll fix that.

Thank you.

ordo-viddler avatar Oct 02 '19 11:10 ordo-viddler

Hi!

I answered your questions and fixed what you requested.

I'm terrible sorry that I did this 8 days after your request, but I was on vacation.

Thanks and let me know if any further information are needed.

ordo-viddler avatar Oct 16 '19 13:10 ordo-viddler

Hi there!

Thank you for checking and reviewing my attempt for to add_on_usage support in you library. As it appears it does not fit, I'll close this PR to keep things clean.

Thanks!

ordo-viddler avatar Oct 29 '19 11:10 ordo-viddler

Hi @ordo-viddler, apologies for the delay as I've been very busy.

I really appreciate the PR -- the holdup has been mostly thinking about the query param being exported, and the time to look through the Recurly docs to gather more context. Would love to have you reopen this so we can add to the repo.

cristiangraz avatar Oct 29 '19 17:10 cristiangraz

Hi Sure, I just wanted to keep things clean.

ordo-viddler avatar Nov 04 '19 10:11 ordo-viddler