StarRatingBundle icon indicating copy to clipboard operation
StarRatingBundle copied to clipboard

add function resettable

Open marcelglaeser opened this issue 7 years ago • 7 comments

marcelglaeser avatar Mar 23 '17 18:03 marcelglaeser

Hi @marcelglaeser

Thanks for the pull request. It looks like you're adding an icon at the end of the stars to reset the value back to 0, which is a good catch considering that was not an included feature before. Thanks.

My only comment for improvement in the readme is to include a picture of what reset looks like when enabled since it may not be immediately obvious. Thoughts?

blackknight467 avatar Mar 23 '17 19:03 blackknight467

You mean a picture like that? resettable

marcelglaeser avatar Mar 23 '17 19:03 marcelglaeser

exactly like that! Just include it under the

to enable resetable

and include a note about the resetable functionality and that it will reset the star value to 0.

blackknight467 avatar Mar 23 '17 19:03 blackknight467

Done. So okay? :)

marcelglaeser avatar Mar 24 '17 09:03 marcelglaeser

I don't use the twig extension!

marcelglaeser avatar Mar 24 '17 09:03 marcelglaeser

Is it possible to merge this PR please ?

FloFrad avatar Jun 06 '17 10:06 FloFrad

Hi, can you merge this please?

marcelglaeser avatar Jul 10 '19 06:07 marcelglaeser