blackcandy icon indicating copy to clipboard operation
blackcandy copied to clipboard

Lookup album image from Discogs if possible if attaching from file fails

Open jaredmoody opened this issue 2 years ago • 3 comments

When syncing the media library, album art is looked up from the file, and if not found, is left blank even when the art can be found on discogs.

This change automatically queues a job to attempt to attach the album art from discogs if not found when attaching from the file - and discogs lookup is available.

jaredmoody avatar Jun 05 '22 05:06 jaredmoody

Pull Request Test Coverage Report for Build 2442332217

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 96.847%

Totals Coverage Status
Change from base Build 2427163858: 0.008%
Covered Lines: 768
Relevant Lines: 793

💛 - Coveralls

coveralls avatar Jun 05 '22 05:06 coveralls

My goal here is to have all images automatically loaded on Media sync. Currently in my library I have a lot of missing images and they don't get loaded until I click into the album, which is strange behavior to me.

However, I'm worried that this may cause a rate limit issue on the discogs api, need to investigate.

jaredmoody avatar Jun 05 '22 07:06 jaredmoody

According to the doc of discogs API https://www.discogs.com/developers#page:home,header:home-rate-limiting. There are some custom http headers we can use to track the rate limit of the API.

aidewoode avatar Jun 06 '22 02:06 aidewoode

Hi, since this PR hasn't been updated for a long time. I made a continuation of this PR: https://github.com/blackcandy-org/black_candy/pull/343. So I will close this PR. Thanks for your contribution.

aidewoode avatar Feb 02 '24 01:02 aidewoode