Firefox-UI-Fix icon indicating copy to clipboard operation
Firefox-UI-Fix copied to clipboard

Animation problem with `userChrome.tab.bottom_rounded_corner`

Open Nomes77 opened this issue 2 years ago • 4 comments

Describe the bug

There is a problem with the animation of the bottom_rounded_corners. When you select or hover a tab you see first the corners appearing and then the background of the tab. If I disable the following rule, there is no problem anymore:

button,
toolbarbutton,
stack,
vbox,
.toolbarbutton-icon,
#tabs-newtab-button > .toolbarbutton-icon {
  transition: background-color 1s var(--animation-easing-function) !important;
}
button:hover,
toolbarbutton:hover,
stack:hover,
vbox:hover,
.toolbarbutton-icon:hover,
#tabs-newtab-button:hover > .toolbarbutton-icon {
  transition: background-color 0.25s var(--animation-easing-function) !important;
}

You can see it very good when userChrome.tab.bottom_rounded_corner_edge of chrome is enabled

Expected behavior

The animation is also for the tab_bottom_corners

Screenshots

I was able to capture a screenshot midway: afbeelding Also when loading of a tab is finished, you can can see it: afbeelding

OS

Windows 10

OS - Others

No response

Firefox Version

108.0.1

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup
userChrome.decoration.animate
userChrome.tab.connect_to_window
userChrome.tab.dynamic_separator
userChrome.tab.box_shadow
userChrome.tab.bottom_rounded_corner
userChrome.tab.bottom_rounded_corner.all
userChrome.tab.bottom_rounded_corner.edge

Additional context

No response

Nomes77 avatar Jan 03 '23 07:01 Nomes77

So you think that animation is not filled within the tab width, but it is cropped?

Aleksandra0056 avatar Jan 06 '23 17:01 Aleksandra0056

Well, if I am right, then the australis is affected too (Because I have it enabled).

Aleksandra0056 avatar Jan 06 '23 17:01 Aleksandra0056

Yes, australis is effected to. That animation is within the tab width. But the corners are put on top of it and are not animated. So, at least I, I see a second difference.

Nomes77 avatar Jan 09 '23 07:01 Nomes77

I think that this would be difficult to fix, but maybe I am wrong. Because the bottom rounded corners are images and I think that it would be difficult to animate the bottom rounded corner images (or bottom rounded corner icons). The bottom rounded corner images are located here: https://github.com/black7375/Firefox-UI-Fix/tree/master/icons

Aleksandra0056 avatar Jan 15 '23 15:01 Aleksandra0056