Firefox-UI-Fix icon indicating copy to clipboard operation
Firefox-UI-Fix copied to clipboard

Mute Tab button too big on Pinned Tabs

Open ghnp5 opened this issue 1 year ago • 12 comments

Describe the bug

Hi!

The Mute Tab button is a bit obtrusive in pinned tabs, as they take a lot of space, making it hard to click to open the tab.

image

image

Would it be possible to make it smaller? :)

Many thanks!

Expected behavior

No response

Screenshots

No response

OS

Windows 11

OS - Others

No response

Firefox Version

132.0b5 (64-bit)

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup is just the default - no changes

Additional context

No response

ghnp5 avatar Oct 09 '24 22:10 ghnp5

This is a bug i have too, it should be a speaker logo not a circle

ctrlcmdshft avatar Oct 10 '24 16:10 ctrlcmdshft

Same bug here, circle instead of speaker.

plissken1138 avatar Oct 15 '24 18:10 plissken1138

Thanks - but just to clarify - besides the circle, I'm also reporting that the button is too big, making it hard to select the pinned tab.

ghnp5 avatar Oct 15 '24 19:10 ghnp5

found this bug on normal tab too. (on nightly build 133.0a1)

2024-10-17_22-58-45

sakuhanachan avatar Oct 17 '24 14:10 sakuhanachan

image

How it normally looks like

image

How it looks like when you hover over it

I also have the same issue of the tab speaker icon being a circle. Firefox Developer Edition v132.0b9 (64-bit) Original Lepton version v8.6.3 Windows 11 Theme System Default.

adamkkkkkk avatar Oct 21 '24 17:10 adamkkkkkk

Confirming the same issue on the latest release Firefox 132.0

ajchow66 avatar Oct 29 '24 14:10 ajchow66

Thank you for the report. It will probably be dealt with in the #1011 .

black7375 avatar Nov 28 '24 13:11 black7375

@black7375 - Thanks, but I'm not sure #1011 is the same thing I'm reporting here.

What I'm reporting is that the button is too big on pinned tabs.

I keep accidentally removing the Mute on pinned tabs, because I want to click to open the tab, but instead, I click on the "Unmute" button, so I have to go right click to mute again.

Is it possible to fix this, making the button much smaller?

Thank you!

ghnp5 avatar Nov 28 '24 13:11 ghnp5

@ghnp5 It currently consists of 17x17 pixels.

  • 17x17 (Currently) image image

  • 16x16 image image

  • 15x15 image image

  • 14x14 image image

14x14 certainly seems small. It looks more appropriate if it's slightly reduced to 16x16. What do you think?

black7375 avatar Nov 28 '24 14:11 black7375

Thank you very much for showing the examples.

I think the problem also is that there is some padding around the icon, which makes the button bigger than it seems while we're not hovering it. If it's possible to remove the padding (or making it just 1px padding or so), on that 14x14, maybe the icon will be more visible than it is in your screenshot.

What do you think? 14x14, with 1px padding around the icon, so the icon can be a bit bigger.

I just feel that reducing from 17x17 to 16x16 might not really resolve my problem :)

Many thanks!

ghnp5 avatar Nov 28 '24 14:11 ghnp5

Also - is it possible to make this change only for pinned tabs?

So the other normal tabs aren't affected.

Not sure if there's some extra parent class or so, to narrow the CSS change...

Thanks!

ghnp5 avatar Nov 28 '24 14:11 ghnp5

In my opinion, the sizes should be uniform for consistency. I'll think a little more about the appropriate method.

black7375 avatar Nov 28 '24 21:11 black7375