security-tools icon indicating copy to clipboard operation
security-tools copied to clipboard

Pylint alerts corrections as part of intervention experiment

Open evidencebp opened this issue 1 year ago • 2 comments

I'd like to conduct a software engineering experiment regarding the benefit of Pylint alerts removal. The experiment is described here. In the experiments, Pylint is used with some specific alerts, files are selected for intervention and control. After the interventions are done, one can wait and examine the results.

I'm asking for your approval for conducting an intervention in your repository.

See examples of interventions in stanford-oval/storm, gabfl/vault, and coreruleset/coreruleset.

You can see the planed interventions

@bl4de , may I do the interventions?

evidencebp avatar Nov 03 '24 16:11 evidencebp

Hi @evidencebp,

Yes, no problem.

bl4de avatar Nov 06 '24 09:11 bl4de

@bl4de , I created a PR that fixes the alerts. Change are rather small. Please see if it is OK.

Before merging, I'd like to discuss you on two more alerts.

In the file nodestructor\nodestructor.py there is an broad-exception-caught on line 382 A broad exception might hide unexpected exception types and therefore it is recommended to catch specific exception. I could not understand which exceptions are expected there. Can you consult me?

Also, in the file jwt_decoder.py there are too long lines. Ussally adding a new line solves tat but these lines are:

eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOiIxNDE2OTI5MDYxIiwianRpIjoiODAyMDU3ZmY5YjViNGViN2ZiYjg4NTZiNmViMmNjNWIiLCJzY29wZXMiOnsidXNlcnMiOnsiYWN0aW9ucyI6WyJyZWFkIiwiY3JlYXRlIl19LCJ1c2Vyc19hcHBfbWV0YWRhdGEiOnsiYWN0aW9ucyI6WyJyZWFkIiwiY3JlYXRlIl19fX0.gll8YBKPLq6ZLkCPLoghaBZG_ojFLREyLQYx0l2BG3E

eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOiIxNDE2OTI5MDYxIiwianRpIjoiODAyMDU3ZmY5YjViNGViN2ZiYjg4NTZiNmViMmNjNWIiLCJzY29wZXMiOnsidXNlcnMiOnsiYWN0aW9ucyI6WyJyZWFkIiwiY3JlYXRlIl19LCJ1c2Vyc19hcHBfbWV0YWRhdGEiOnsiYWN0aW9ucyI6WyJyZWFkIiwiY3JlYXRlIl19fX0.15308fa263baaa57c2c84528d913ab75892352d927ccbd29e5af8fd783257996

What are these lines?

evidencebp avatar Nov 06 '24 16:11 evidencebp